Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODULE.bazel to Starlark language #6279

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Add MODULE.bazel to Starlark language #6279

merged 3 commits into from
Feb 27, 2023

Conversation

jsharpe
Copy link
Contributor

@jsharpe jsharpe commented Feb 6, 2023

Description

Adds filenames that are used by the new bzlmod format introduced in bazel 5.0.0 as an experimental feature and released in bazel 6.0.0.
Also added copy.bara.sky which is the main configuration file for Google's copybara tool.

Checklist:

@jsharpe jsharpe requested a review from a team as a code owner February 6, 2023 09:35
@lildude
Copy link
Member

lildude commented Feb 6, 2023

Of these, only MODULE.bazel has sufficient popularity on GitHub for inclusion right now. The others are a long way off our usage requirements.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@jsharpe jsharpe changed the title Add bzlmod filenames and copybara config file to starlark language Add bazel bzlmod MODULE.bazel to starlark language Feb 6, 2023
@jsharpe
Copy link
Contributor Author

jsharpe commented Feb 6, 2023

Of these, only MODULE.bazel has sufficient popularity on GitHub for inclusion right now. The others are a long way off our usage requirements.

Have update the PR to remove the ones that don't meet usage requirements. WORKSPACE.bzlmod is just a file that is used during transition to bzlmod so its usage will be expected to be low as bzlmod is adopted.

@jsharpe
Copy link
Contributor Author

jsharpe commented Feb 6, 2023

Do you need me to add a sample MODULE.bazel file?

@lildude
Copy link
Member

lildude commented Feb 17, 2023

Do you need me to add a sample MODULE.bazel file?

Yes please.

@lildude lildude changed the title Add bazel bzlmod MODULE.bazel to starlark language Add MODULE.bazel to Starlark language Feb 27, 2023
@lildude
Copy link
Member

lildude commented Feb 27, 2023

Yes please.

NM. I've added one directly to your branch.

@jsharpe
Copy link
Contributor Author

jsharpe commented Feb 27, 2023

Yes please.

NM. I've added one directly to your branch.

Thanks! Apologies for the lack of response sooner.

@lildude lildude merged commit 89f4df5 into github-linguist:master Feb 27, 2023
@jsharpe jsharpe deleted the patch-1 branch February 27, 2023 10:49
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants