Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Phel language #6282

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JesusValera
Copy link

@JesusValera JesusValera commented Feb 10, 2023

Add Phel programming language to linguist.

Issue: phel-lang/phel-lang#158

Description

There are more than 180 files in Github using the .phel extension and some projects were created from scratch like

Checklist:

The last two points are not selected because, it uses a Common Lisp grammar & the extension is unique (.phel).


Please, let me know if something is missing, glad to keep improving the PR if necessary!

@JesusValera JesusValera requested a review from a team as a code owner February 10, 2023 16:20
Copy link

@Chemaclass Chemaclass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Highlighting phel files using common lisp would be a great improvement, especially people will be able to understand the code easier when reading it directly from GitHub 🧠💡

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Popularity is not sufficient for inclusion yet, but that doesn't mean you can't address the identified issues in the mean time.

See inline comment.

Please remove the core.phel file. It's massive and waaaay too big.

Please also remove the sample.phel file as this is clearly a "Hello world" sample and not a real-world example.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants