Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '.cppm' files as C++ sources. #6310

Merged
merged 6 commits into from
Mar 8, 2023

Conversation

robert-andrzejuk
Copy link
Contributor

@robert-andrzejuk robert-andrzejuk commented Mar 5, 2023

It is becoming common to use "cppm" or "ixx" as extension for C++ modules. This is standard C++ code.
"ixx" is already on the list.

Reference: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5926

Description

Checklist:

It is becoming common to use "cppm" or "ixx" as extension for C++ modules.
This is standard C++ code.
"ixx" is already on the list.

Reference: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5926
@robert-andrzejuk robert-andrzejuk requested a review from a team as a code owner March 5, 2023 22:19
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read and follow the instructions in the CONTRIBUTING.md file for adding a new extension. Please also fill the approproate section of the template in the OP.

@robert-andrzejuk
Copy link
Contributor Author

@lildude
I edited my post to add the link to the github query: https://github.com/search?q=path%3A*.cppm&type=code
Is that all that is required?

@lildude
Copy link
Member

lildude commented Mar 8, 2023

Nope. You have missed the point in the CONTRIBUTING.md file about preferring real world samples. You've clearly added a "hello world" sample which is never considered real world code. Please add a real world sample and update the OP to link to the source and state the license of the sample.

@robert-andrzejuk
Copy link
Contributor Author

Ok. Thanks for you help.

I copied a file from a repository. And attached it in samples/C++ section.
Also updated my original post (OP). (OP was an unknown abbreviation to me, till now.)

lib/linguist/languages.yml Outdated Show resolved Hide resolved
@lildude lildude merged commit 4042151 into github-linguist:master Mar 8, 2023
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants