Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clue language #6356

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

Markos-Th09
Copy link

@Markos-Th09 Markos-Th09 commented Apr 3, 2023

Description

This PR adds the clue language to linguist.
Closes #6305

Checklist:

@Markos-Th09 Markos-Th09 requested a review from a team as a code owner April 3, 2023 04:41
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@Markos-Th09 Markos-Th09 requested a review from Alhadis April 3, 2023 04:59
samples/Clue/array.clue Outdated Show resolved Hide resolved
@Alhadis Alhadis changed the title Add clue language Add Clue language Apr 3, 2023
Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Markos-Th09 Regarding your question about "unacceptable samples", the following files appear to be fixtures for testing syntax-parsing, or an example code-snippet taken from a tutorial:

The following samples are good examples of realistic, practical uses for Clue (and ideally what you should be aiming for when selecting samples):

@Markos-Th09
Copy link
Author

@Markos-Th09 Regarding your question about "unacceptable samples", the following files appear to be fixtures for testing syntax-parsing, or an example code-snippet taken from a tutorial:

The following samples are good examples of realistic, practical uses for Clue (and ideally what you should be aiming for when selecting samples):

Thanks I think we have some more of these.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These samples are much better, thanks!

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't accept this grammar without a license. Please find another grammar or license your grammar with one of these licenses and add the cached license file to this PR (run bundle exec licensed cache -c vendor/licenses/config.yml once you've added a license file and pulled the latest SHA into this PR).

@Markos-Th09
Copy link
Author

Markos-Th09 commented Apr 3, 2023

We can't accept this grammar without a license. Please find another grammar or license your grammar with one of these licenses and add the cached license file to this PR (run bundle exec licensed cache -c vendor/licenses/config.yml once you've added a license file and pulled the latest SHA into this PR).

The grammar is licensed under MIT.

@lildude
Copy link
Member

lildude commented Apr 3, 2023

Usage is really low for inclusion right now too.

@lildude
Copy link
Member

lildude commented Apr 3, 2023

The grammar is licensed under MIT.

Not according to the repo:

CleanShot 2023-04-03 at 11 10 21

We need a license file.

@Markos-Th09
Copy link
Author

The grammar is licensed under MIT.

Not according to the repo:

CleanShot 2023-04-03 at 11 10 21

We need a license file.

It is intended to be licensed under MIT. I don't know what happened but I will add the license as soon as I can.

@Markos-Th09
Copy link
Author

Resolved

@Markos-Th09 Markos-Th09 requested a review from lildude April 3, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Language: Clue
3 participants