Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trailing whitespace & empty lines #6385

Merged
merged 2 commits into from
May 30, 2023
Merged

Conversation

michidk
Copy link
Contributor

@michidk michidk commented Apr 22, 2023

Fix trailing whitespace & empty lines in various files

@michidk michidk requested a review from a team as a code owner April 22, 2023 10:46
@Alhadis Alhadis changed the title Fix formatting in various files Fix trailing whitespace Apr 25, 2023
@michidk michidk changed the title Fix trailing whitespace Fix trailing whitespace & empty lines Apr 27, 2023
@github-linguist github-linguist deleted a comment Apr 29, 2023
@michidk
Copy link
Contributor Author

michidk commented May 2, 2023

Hey @lildude, is there anything blocking this from getting merged?

@lildude
Copy link
Member

lildude commented May 2, 2023

Hey @lildude, is there anything blocking this from getting merged?

Not really, but as it's not actually making any real changes, I've not given it any priority and won't until I have the time, which may only be when I'm preparing the next release.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProTip: these kinds of PRs are often not taken very kindly by many projects which don't use space-sensitive languages, especially as it was a common tactic used to game Hacktoberfest. In future, I encourage you to include real useful code changes along with whitespace changes, but if you must do just a whitespace PR, certainly don't chase it up 😉

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@michidk
Copy link
Contributor Author

michidk commented May 8, 2023

I separated this PR by intent since it concerns multiple files and makes it easier to review that when mashed together with my other PR. The reason why I made this PR is that I had a auto formatter running in my IDE when developing my other PR, and I always had to make sure to not to commit the format changes that did not concern my code, which was quite annoying.
I like to keep my PRs on topic only and think that putting changes that are not related to the actual PR in the same one is bad practice.

@lildude lildude requested a review from a team as a code owner May 30, 2023 09:13
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit b6c3b15 May 30, 2023
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants