Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lkml extension to LookML #6443

Merged
merged 1 commit into from Jun 7, 2023
Merged

Add lkml extension to LookML #6443

merged 1 commit into from Jun 7, 2023

Conversation

lildude
Copy link
Member

@lildude lildude commented Jun 6, 2023

Description

Add .lkml and make it the primary language of LookML as it is way more popular than .lookml.

Checklist:

  • I am adding a new extension to a language.
    • The new extension is used in hundreds of repositories on GitHub.com
    • [-] I have included a real-world usage sample for all extensions added in this PR:
      Not needed as we already have two
    • [-] I have included a change to the heuristics to distinguish my language from others using the same extension.
      N/A

Fixes #6287

@lildude lildude marked this pull request as ready for review June 6, 2023 10:33
@lildude lildude requested a review from a team as a code owner June 6, 2023 10:33
@Alhadis Alhadis changed the title Add lkml extension to LookML Add lkml extension to LookML Jun 7, 2023
@lildude lildude merged commit 4696ae4 into master Jun 7, 2023
5 checks passed
@lildude lildude deleted the lildude/expand-lookml branch June 7, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alhadis Alhadis Alhadis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add extension for LookML: .lkml
2 participants
@lildude @Alhadis