Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Luau language #6612

Merged
merged 34 commits into from
Jun 7, 2024
Merged

Add Luau language #6612

merged 34 commits into from
Jun 7, 2024

Conversation

robloxiandemo
Copy link
Contributor

@robloxiandemo robloxiandemo commented Nov 11, 2023

Description

Resolving this issue, this PR aims to finally add Luau support to the platform.

Checklist:

@robloxiandemo robloxiandemo requested a review from a team as a code owner November 11, 2023 08:17
@robloxiandemo
Copy link
Contributor Author

Hey! I'd like to ask if a CI could be ran for this, as I wasn't able to check it myself under the fork.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
@moo1210
Copy link

moo1210 commented Nov 11, 2023

I strongly support including support for Luau, which for context is an open-source Lua 5.1 fork, with many backward-compatible features (and therefore syntax) changes built onto it over the years.

With that being said, I do think it's worth noting that Vector3 (or any other Roblox types/globals) probably shouldn't be included in this. Standalone Luau has no built-in Vector3 type or globals such as game, this seems largely out of scope.

@robloxiandemo
Copy link
Contributor Author

I'll be going through to fix up my commits with your suggested changes, thank you!

@robloxiandemo
Copy link
Contributor Author

I strongly support including support for Luau, which for context is an open-source Lua 5.1 fork, with many backward-compatible features (and therefore syntax) changes built onto it over the years.

With that being said, I do think it's worth noting that Vector3 (or any other Roblox types/globals) probably shouldn't be included in this. Standalone Luau has no built-in Vector3 type or globals such as game, this seems largely out of scope.

I will say that it seems the larger scope of usage of Luau is under the Roblox platform.

@phoriah
Copy link

phoriah commented Nov 14, 2023

I strongly support including support for Luau, which for context is an open-source Lua 5.1 fork, with many backward-compatible features (and therefore syntax) changes built onto it over the years.
With that being said, I do think it's worth noting that Vector3 (or any other Roblox types/globals) probably shouldn't be included in this. Standalone Luau has no built-in Vector3 type or globals such as game, this seems largely out of scope.

I will say that it seems the larger scope of usage of Luau is under the Roblox platform.

I agree with this, better have them just in case.

@phoriah
Copy link

phoriah commented Nov 14, 2023

    * Hex value: `#14a5ff`
    * Rationale: Logo color from https://luau-lang.org/ at the time of writing.

Any chance you could update the color to #479df9 ?
Not sure where you got yours from
image
image

@phoriah
Copy link

phoriah commented Nov 14, 2023

@robloxiandemo

@robloxiandemo
Copy link
Contributor Author

    * Hex value: `#14a5ff`
    * Rationale: Logo color from https://luau-lang.org/ at the time of writing.

Any chance you could update the color to #479df9 ? Not sure where you got yours from image image

Sure, I'll submit a commit for this now.

@robloxiandemo
Copy link
Contributor Author

    * Hex value: `#14a5ff`
    * Rationale: Logo color from https://luau-lang.org/ at the time of writing.

Any chance you could update the color to #479df9 ? Not sure where you got yours from image image

Resolved here, thank you for your contribution!

@lewisakura
Copy link

lewisakura commented Nov 17, 2023

I do hate to add to the color debate, but neither of those colors is correct for the logo. The logo uses #00A2FF:

https://github.com/luau-lang/site/blob/c4e26ca38e3d075a365f548951f05a9be0eda345/logo.svg?short_path=5525394#L2

@robloxiandemo
Copy link
Contributor Author

I do hate to add to the color debate, but neither of those colors is correct for the logo. The logo uses #00A2FF:

https://github.com/luau-lang/site/blob/c4e26ca38e3d075a365f548951f05a9be0eda345/logo.svg?short_path=5525394#L2

Haha, thank you for pointing that out, I'll write up a commit later today to resolve that. 👍

@robloxiandemo
Copy link
Contributor Author

I do hate to add to the color debate, but neither of those colors is correct for the logo. The logo uses #00A2FF:

https://github.com/luau-lang/site/blob/c4e26ca38e3d075a365f548951f05a9be0eda345/logo.svg?short_path=5525394#L2

Resolved here, thank you for your contribution!

@robloxiandemo
Copy link
Contributor Author

Seems we'll have to make some changes with the grammar. I'll try to submit a few PRs later this week to resolve it.

@phoriah
Copy link

phoriah commented Apr 19, 2024

Your new samples are all now too big. If they're suppressed in the diff, they're bigger than we need. Also, we don't need all the other grammar updates.

Is there anything else that still needs changing? 🤔

@lildude
Copy link
Member

lildude commented Apr 19, 2024

Your new samples are all now too big. If they're suppressed in the diff, they're bigger than we need. Also, we don't need all the other grammar updates.

Is there anything else that still needs changing? 🤔

Yes. All the submodule updates need to be reverted. We only need the files for this language updated.

@AsynchronousAI
Copy link

Your new samples are all now too big. If they're suppressed in the diff, they're bigger than we need. Also, we don't need all the other grammar updates.

Is there anything else that still needs changing? 🤔

Yes. All the submodule updates need to be reverted. We only need the files for this language updated.

Ight bet, Im on a codespace rn fixing.

Enhancement: Replace the signal sample.
This reverts commit 2f9a8a2.

Revert "Enhancement: Update old samples and their sources."

This reverts commit d005379.
@CompeyDev
Copy link

@robloxiandemo If you're looking for more samples, I have a project, rusty-luau, which uses a lot of luau-specific features (such as types), consider that!

@deviaze
Copy link

deviaze commented May 4, 2024

Most of those examples still seem to showcase relatively advanced type features that I don't think represent the bulk of the language,

Luau is an extremely useful scripting language, not just on the Roblox platform, but also for general purpose programming with the Lune runtime. It's an amazing replacement for bash/powershell scripts, python, and other high level dynamically typed scripting languages--without needing any of the baggage to install or run. Imho, Luau excels in its simplicity, ease of use, and performance.

If possible, I'd like to contribute some simple, general-purpose script examples that demonstrate this side of the language but still differentiate it from Lua 5.1.

@robloxiandemo
Copy link
Contributor Author

@robloxiandemo If you're looking for more samples, I have a project, rusty-luau, which uses a lot of luau-specific features (such as types), consider that!

I'll look over them and update each, though I've done it so many times already, 😅

@robloxiandemo
Copy link
Contributor Author

If possible, I'd like to contribute some simple, general-purpose script examples that demonstrate this side of the language but still differentiate it from Lua 5.1.

Feel free to, just make sure to mention me somewhere along with the example and any related real-world usage, been finding it a tad bit difficult to find outside of Roblox examples without there just being comment spam (or having far too many lines).

@robloxiandemo robloxiandemo requested a review from lildude May 5, 2024 19:39
@phoriah
Copy link

phoriah commented Jun 5, 2024

@lildude Sorry for pinging again, but any updates? Or, are there still changes that need to be made..?

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit 0204ffa Jun 7, 2024
5 checks passed
@bradsharp
Copy link

bradsharp commented Jun 11, 2024

The color should be #00A2FF. Disregard, it looks like the correct one was used in the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet