Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlighting and correct file extensions for TI Program #6688

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

TIny-Hacker
Copy link
Contributor

@TIny-Hacker TIny-Hacker commented Jan 25, 2024

This PR adds highlighting and updates file extensions for the already existing TI Program language in linguist, which was added in #3258.

Description

I've created and added a syntax highlighting grammar for all tokens in the TI-BASIC programming language, which is detected as TI Program by linguist. I've chosen not to change the name TI Program to TI-BASIC as the are a few community-created languages for the TI-83 / 84 Plus family which also fall under the TI Program label, as mentioned in #6295. This grammar applies to those languages as well, as they re-use the same tokens as TI-BASIC, meaning that they can and should still all fall under the TI Program label.

I've also removed the .8xk and .8xk.txt extension and replaced it with .83p and .83p.txt, as discussed in #6295. The .8xk extension and variants are only used by binary files, not source, meaning that it does not make sense to include them in linguist.

I've also added samples for .8xp, which currently has no samples.

Checklist:

@TIny-Hacker TIny-Hacker requested a review from a team as a code owner January 25, 2024 20:40
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit 32cc169 Mar 8, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants