Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Edge Language #6695

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

evoactivity
Copy link
Contributor

@evoactivity evoactivity commented Feb 4, 2024

Adds the edge templating language used by AdonisJS
https://edgejs.dev/

Checklist:

@evoactivity evoactivity requested a review from a team as a code owner February 4, 2024 20:22
@evoactivity
Copy link
Contributor Author

evoactivity commented Feb 4, 2024

One question I have is the grammar includes source.js#expression which is not available in the atom javascript textmate grammar, but is available in the microsoft grammar. I think GitHub uses the treesitter grammar for javascript, but I assume it will use the textmate grammar when being included by another textmate grammar. Can you confirm if my assumption is correct about using the textmate grammar when included by another textmate grammars, and if so which version of the grammar is in use.

@thetutlage If the atom grammar is being used I'd recommend updating the edge grammar to include source.ts#expression instead.

@lildude
Copy link
Member

lildude commented Feb 5, 2024

I think GitHub uses the treesitter grammar for javascript,

Correct a denoted by the 🐌 in the list of grammers README.md

but I assume it will use the textmate grammar when being included by another textmate grammar. Can you confirm if my assumption is correct about using the textmate grammar when included by another textmate grammars,

It is.

and if so which version of the grammar is in use.

The latest SHA of the repo the submodule points to.

@evoactivity
Copy link
Contributor Author

Thanks for the confirmations @lildude

I've made the required updates to the edge grammar, so everything should be fine from our end now. I've tested the updated grammar with nova lightshow and all seems to be working great :)

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one request: please change the sample for a real-real world sample; this appears to be a "Hello World" type example.

@evoactivity
Copy link
Contributor Author

Done 🙂

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit 27b2b66 Mar 8, 2024
5 checks passed
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants