-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Edge Language #6695
Add Edge Language #6695
Conversation
One question I have is the grammar includes @thetutlage If the atom grammar is being used I'd recommend updating the edge grammar to include |
Correct a denoted by the 🐌 in the list of grammers README.md
It is.
The latest SHA of the repo the submodule points to. |
Thanks for the confirmations @lildude I've made the required updates to the edge grammar, so everything should be fine from our end now. I've tested the updated grammar with nova lightshow and all seems to be working great :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just one request: please change the sample for a real-real world sample; this appears to be a "Hello World" type example.
Done 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Adds the edge templating language used by AdonisJS
https://edgejs.dev/
Checklist:
#0dffe0