Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pip Requirements language #6739

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

spenserblack
Copy link
Contributor

@spenserblack spenserblack commented Mar 7, 2024

This language is a text file that lists requirements for the pip install command, most commonly a list of packages with optional version constraints.

Checklist:

This language is a text file that lists requirements for the
`pip install` command, most commonly a list of packages with optional
version constraints.
@spenserblack spenserblack marked this pull request as ready for review March 7, 2024 17:35
@spenserblack spenserblack requested a review from a team as a code owner March 7, 2024 17:35
@spenserblack
Copy link
Contributor Author

I wasn't sure if heuristics are needed because, while these files do conflict with the .txt extension, this language only adds filenames, which as I understand take higher priority over extensions.

There might need to be some discussion on the language's name -- according to the docs, another name is "pip requirements.txt files".

@spenserblack spenserblack marked this pull request as draft March 7, 2024 17:45
@spenserblack spenserblack marked this pull request as ready for review March 7, 2024 18:01
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and there shouldn't be any conflicts as explicit names take priority. I think the name is a good start.

@lildude lildude added this pull request to the merge queue Mar 8, 2024
Merged via the queue into github-linguist:master with commit aa11c2c Mar 8, 2024
5 checks passed
@spenserblack spenserblack deleted the pip-requirements branch March 8, 2024 17:27
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants