New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common AutoHotkey extensions #6815
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick look at your search links suggests most of these extensions are nowhere near popular enough for inclusion. Your samples are all exactly what we explicitly say do not add too.
Please remove all extensions that don't meet our popularity requirements or aren't close. And replace the samples with real samples.
The heuristic is also unnecessary as Linguist won't use it as it doesn't already know about this extension, which means every file on GitHub will that extension will now be associated with this language, which you might want to think twice about.
You might want to consider using an override instead.
I removed the I'm not too sure what you mean with the heuristics, there are a couple of files like this which share the same extension, but isn't autohotkey |
The heuristic is not considered at all when Linguist only knows one language for an extension. In such a case the language Linguist knows is applied to all files with that extension, unless overridden. In order for the heuristic to be considered, Linguist needs to know of at least two languages using the extension so it can use it to differentiate between the two and make a better identification. So if you want your heuristic to take effect, you will need to identify another other language, and add it to Linguist as part of this PR, assuming it meets the popularity requirements too. That file in question will remain unaffected as the repo already has an override.
Only local to the repo. The other language file you pointed to only has a language and loose syntax highlighting because the repo owner has told Linguist to consider all files in the repo as matlab with this line. |
- ah1 - ah2
All requested changes should be addressed now :) |
Adds common AutoHotkey extensions
Description
Adds the following extensions:
Checklist: