chore: fix broken tests (#474)

github-tools · Sep 26, 2017 · 24223f7 · 24223f7
1 parent 33bee0e
commit 24223f7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/lib/Requestable.js b/lib/Requestable.js
@@ -256,7 +256,7 @@ class Requestable {
             results.push(...thisGroup);
 
             const nextUrl = getNextPage(response.headers.link);
-            if (nextUrl && typeof options.page !== 'number') {
+            if (nextUrl && !(options && typeof options.page !== 'number')) {
                log(`getting next page: ${nextUrl}`);
                return this._requestAllPages(nextUrl, options, cb, results);
             }

diff --git a/test/organization.spec.js b/test/organization.spec.js
@@ -17,11 +17,13 @@ describe('Organization', function() {
          password: testUser.PASSWORD,
          auth: 'basic',
       });
-      return;
+      createdProject = undefined;
    });
 
    after(function() {
-      return github.getProject(createdProject.id).deleteProject();
+      if (createdProject) {
+         return github.getProject(createdProject.id).deleteProject();
+      }
    });
 
    describe('reading', function() {

diff --git a/test/team.spec.js b/test/team.spec.js
@@ -159,7 +159,7 @@ describe('Team', function() { // Isolate tests that need a new team per test
    });
 
    it('should add membership for a given user', function() {
-      return team.addMembership(testUser.USERNAME)
+      return team.addMembership(altUser.USERNAME)
          .then(({data}) => {
             const {state, role} = data;
             expect(state === 'active' || state === 'pending').to.be.true();