Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starring for repositories #205

Closed
ssergienko opened this issue Jul 2, 2015 · 4 comments
Closed

Add starring for repositories #205

ssergienko opened this issue Jul 2, 2015 · 4 comments

Comments

@ssergienko
Copy link

hi, mate.
thanks for you job. use your plugin on a project and have fun )
I've added peace of code for starring of repositories here - ssergienko@76f6b51
don't know why so many changes are displaying, I've just added few lines.
the peace of code is:

// starring
this.isStarred = function(owner, repo, cb) {
_request("GET", "/user/starred/" + owner + '/' + repo, null, function(err,res) {
cb(err,res);
});
};
this.star = function(owner, repo, cb) {
_request("PUT", "/user/starred/" + owner + '/' + repo, null, function(err,res) {
cb(err,res);
});
};
this.unstar = function(owner, repo, cb) {
_request("DELETE", "/user/starred/" + owner + '/' + repo, null, function(err,res) {
cb(err,res);
});
};

hope it'll help

PS: fixed bug with "var btoa". now it works

thanks,
Serge

@aendra-rininsland
Copy link
Member

Hi @ssergienko!

Mind submitting this as a pull request and adding tests? Also, I think you might have changed the indentation because it seems like 95% of the file is rewritten from your commit; please fix that before PR'ing.

Thanks!

@ssergienko
Copy link
Author

ok, I'll try. I'm just very beginner on github, unlike development )

On Thu, 2 Jul 2015 at 13:14 Ændrew Rininsland notifications@github.com
wrote:

Hi @ssergienko https://github.com/ssergienko!

Mind submitting this as a pull request and adding tests? Also, I think you
might have changed the indentation because it seems like 95% of the file is
rewritten from your commit; please fix that before PR'ing.

Thanks!


Reply to this email directly or view it on GitHub
#205 (comment).

@aendra-rininsland
Copy link
Member

@ssergienko No worries! We all start somewhere! Learning to do PRs is a really terrific skill to learn, really helps you become a bonafide member of the open source community. 😄

@AurelioDeRosa
Copy link
Member

Closing this issue as the methods have been introduced with commits bc25f25, 1fd209d, and 15b69aa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants