Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support conditional API requests #53

Open
mikemorris opened this issue Apr 23, 2013 · 5 comments
Open

Support conditional API requests #53

mikemorris opened this issue Apr 23, 2013 · 5 comments

Comments

@mikemorris
Copy link
Contributor

Using Last-Modified``If-Modified-Since or ETag``If-None-Match headers http://developer.github.com/v3/#conditional-requests

@w35l3y
Copy link

w35l3y commented May 21, 2014

👍

I think is it related to #45

@aendra-rininsland
Copy link
Member

Right you are, @w35l3y. Closing as duplicate of #45.

@aendra-rininsland
Copy link
Member

This is actually a separate issue. Reopening.

@aendra-rininsland aendra-rininsland added this to the v0.10.8 milestone Oct 19, 2015
@AurelioDeRosa AurelioDeRosa modified the milestones: 0.12.0, v0.10.8 Jan 24, 2016
@clayreimann clayreimann modified the milestones: 1.x, 0.12.0 Apr 27, 2016
@clayreimann
Copy link
Member

@mikemorris How would you expect such a feature to work? Would we cache all of the requests and then return the previous value if we get 304 Not Modified? Or would you expect to pass a last-modified or ETag as a parameter to the function?

@mikemorris
Copy link
Contributor Author

Decision to cache would likely be made by an implementing app, not here, but yes, I would expect to pass an Etag or last modified date into the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants