Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create travishook.md #336

Closed
wants to merge 2 commits into from
Closed

Create travishook.md #336

wants to merge 2 commits into from

Conversation

Jack-Collins
Copy link

No description provided.

@clayreimann
Copy link
Member

Thanks for the PR, it's a good start but I'm pretty sure your try/catch block isn't an effective method of handling errors.

There shouldn't be anything wrong with the call itself–you're probably trying to handle errors that are thrown by GitHub's api. Those errors will be thrown asynchronously (and since you pass a callback they won't even actually be thrown, they'll be passed into the callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants