Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn why nogofunc sanity check is triggered #63

Closed
kalexmills opened this issue Dec 23, 2020 · 2 comments
Closed

Learn why nogofunc sanity check is triggered #63

kalexmills opened this issue Dec 23, 2020 · 2 comments
Labels
bug Something isn't working vet-bot the issue is part of VetBot's responsibility
Milestone

Comments

@kalexmills
Copy link
Contributor

kalexmills commented Dec 23, 2020

A sanity check added to nogofunc is being triggered, which, for me, is calling into question the accuracy of some of the callgraph procedures.

Based on the symptoms, I suspect one of these:

  1. the callgraph reversal in lazyInitCalledBy is wrong
  2. nogofunc is wrong
  3. the CalledByGraphBFS is wrong
  4. nothing is wrong and I shouldn't expect a BFS finding a path in one direction to also find the same path in the reverse graph (unlikely).
@kalexmills kalexmills added the bug Something isn't working label Dec 23, 2020
@kalexmills kalexmills added this to the General Availability milestone Dec 23, 2020
@kalexmills kalexmills added the vet-bot the issue is part of VetBot's responsibility label Dec 23, 2020
@kalexmills
Copy link
Contributor Author

kalexmills commented Dec 23, 2020

I'm thinking this is actually what happens when a third-party function is reached, so it should have been modified by the most recent changes. I need to convince myself via reading the code. Putting a note here for later.

@kalexmills
Copy link
Contributor Author

Closing in favor of #78.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vet-bot the issue is part of VetBot's responsibility
Projects
None yet
Development

No branches or pull requests

1 participant