This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
MEDEdgeInsets #18
Merged
MEDEdgeInsets #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| #import <AppKit/AppKit.h> | ||
| #endif | ||
|
|
||
| #ifdef __IPHONE_OS_VERSION_MIN_REQUIRED |
There was a problem hiding this comment.
This could be combined with the above block.
|
🍔 |
|
|
||
| MEDEdgeInsets MEDEdgeInsetsFromString(NSString *string) { | ||
| MEDEdgeInsets insets = MEDEdgeInsetsZero; | ||
| if (string) { |
There was a problem hiding this comment.
Style: explicit comparison vs. nil
|
💥 |
|
|
||
| MEDEdgeInsets MEDEdgeInsetsFromString(NSString *string) { | ||
| double top = 0, left = 0, bottom = 0, right = 0; | ||
| if (string != nil) { |
There was a problem hiding this comment.
This should be an assertion instead, IMO.
|
🍟 |
|
Should I switch all edge insets comparisons to using |
|
Ehhh… up to you, as long as the tests for that function don't trust it. |
|
|
|
Ah, sorry, can you also add this to the framework header? |
|
I didn't explicitly add it because |
|
Yes, every public header should be there. |
|
🍸 |
|
🍻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17.
For the
MEDEdgeInsetsgeometry functions, I wasn't sure if you wanted me to reuse the UIKit functions in the iOS implementations, but I reimplemented it for both platforms anyways. This can be switched to use UIKit functions if necessary.