This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
Improve semi-transient behaviour #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -255,7 +259,9 @@ - (void)showRelativeToRect:(CGRect)positioningRect ofView:(NSView *)positioningV | |||
| if (strongSelf.behavior == RBLPopoverBehaviorTransient) { | |||
| shouldClose = !mouseInPopoverWindow; | |||
| } else { | |||
| shouldClose = strongSelf.popoverWindow.parentWindow.isKeyWindow && NSPointInRect(NSEvent.mouseLocation, strongSelf.popoverWindow.parentWindow.frame) && !mouseInPopoverWindow; | |||
| shouldClose = strongSelf.popoverWindow.parentWindow.isKeyWindow && NSPointInRect(NSEvent.mouseLocation, strongSelf.popoverWindow.parentWindow.frame) && !mouseInPopoverWindow && !self.parentWindowResignedKey; | |||
|
Oh yeah... 🚎 |
|
🍍 |
|
🆒 |
joshaber
added a commit
that referenced
this pull request
Jul 9, 2013
Improve semi-transient behaviour
|
I don't understand the intent of this change. 😕 From the docs, it sounds like clicking in the main window should closing the popover. This change seems to require 2 clicks. Can you help me understand what the intent was here? |
|
This was to match |
|
And then drop it into the repo so we can close out #17. |
|
I made a test app in #123. From my testing, it looks like this change breaks the behavior. Maybe there was an |
|
Possibly? If something doesn't match what |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case of first-clicks closing semi-transient popovers.