Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

"Source branch does not exist remotely" being shown when creating PR, though it does exist remotely #455

Closed
grokys opened this issue Jul 27, 2016 · 1 comment
Labels

Comments

@grokys
Copy link
Contributor

grokys commented Jul 27, 2016

Using 2.0.0 RC1 the following message is shown:

image

Even when the source branch does exist remotely.

This is happening because BranchValidator is first called with null before being called with the BranchModel.

@grokys
Copy link
Contributor Author

grokys commented Jul 27, 2016

Looking into this more, what is happening is:

  • Branches is set from Initialize
  • Because Branches has changed the UI layer's selection is no longer valid so it sets its selection to null
  • This selection is two-way bound to SourceBranch so this is set to null
  • The BranchValidator notices this and things that the source branch doesn't exist remotely
  • This line is then triggered, setting the SourceBranch
  • BranchValidator is called again with the correct info and the validation passes, but at this point it's too late - the notification has already been sent.

@paladique paladique added the bug label Jul 27, 2016
grokys added a commit that referenced this issue Jul 28, 2016
Don't try to validate source branch using `BranchValidator` while initialization is in progress. Fixes #455.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants