Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Update to Octokit.GraphQL to 0.1.0 #1767

Merged
merged 11 commits into from Jul 12, 2018
Merged

Conversation

StanleyGoldman
Copy link
Contributor

@StanleyGoldman StanleyGoldman commented Jun 28, 2018

Update Octokit.GraphQL to 0.1.0-beta version from nuget.org

Fixes #1774.

@grokys
Copy link
Contributor

grokys commented Jul 11, 2018

I think lib/Octokit.GraphQL.0.0.6-alpha.nupkg can be removed, right?

@grokys
Copy link
Contributor

grokys commented Jul 11, 2018

Regarding the CI failures,I'm not sure why they're failing now when they weren't failing before, but at one point I had to add a binding redirect to the unit tests project, before it was split apart:

https://github.com/github/VisualStudio/pull/1501/files#diff-1567700eee9e01c12d5752e9988072a1R7

You might have to add a similar config to all the unit test projects.

It seems strange that it worked without this on 10.0 but not on 9.0 though!

@grokys grokys changed the title Update to Octokit.GraphQL to 0.6-alpha Update to Octokit.GraphQL to 0.1.0 Jul 12, 2018
@grokys grokys changed the base branch from refactor/pr-list to master July 12, 2018 08:14
Copy link
Contributor

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but the version is marked as 0.1.0-alpha. Shouldn't 0.1.0 be beta? Also we should probably upload it to nuget.org and use the package from there?

Copy link
Contributor

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now using 0.1.0-beta from nuget.org.

@StanleyGoldman
Copy link
Contributor Author

Nice..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants