Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Pull Request conversation view #2017

Merged
merged 73 commits into from Feb 21, 2019
Merged

Pull Request conversation view #2017

merged 73 commits into from Feb 21, 2019

Commits on Oct 26, 2018

  1. Show document pane for PR conversation. 

    It's currently empty, but it shows. Only supported method of showing is currently right-click on PR list.
    @grokys
    grokys committed Oct 26, 2018
    Copy the full SHA
    38cae06 View commit details
    Browse the repository at this point in the history

  2. Display PR details in document pane. 

    Next need to refactor out a common base class and create 2 different PR detail view models.
    @grokys
    grokys committed Oct 26, 2018
    Copy the full SHA
    50b04ac View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2018

  1. Initial implementation of PR conversation view.

    @grokys
    grokys committed Oct 30, 2018
    Copy the full SHA
    cfb1dd3 View commit details
    Browse the repository at this point in the history

  2. Display sample data in PR conversation page.

    @grokys
    grokys committed Oct 30, 2018
    Copy the full SHA
    02bc4ee View commit details
    Browse the repository at this point in the history

  3. Load PR timeline from GraphQL. 

    And display its commits and comments in the conversation view.
    @grokys
    grokys committed Oct 30, 2018
    Copy the full SHA
    102e337 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. Show commit in TE when OID clicked.

    @grokys
    grokys committed Oct 31, 2018
    Copy the full SHA
    424439d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Display PR title as pane caption.

    @grokys
    grokys committed Nov 1, 2018
    Copy the full SHA
    f976412 View commit details
    Browse the repository at this point in the history

  2. Display an "Add comment" box at the bottom of a PR.

    @grokys
    grokys committed Nov 1, 2018
    Copy the full SHA
    abeb1b8 View commit details
    Browse the repository at this point in the history

  3. Change close issue caption when comment has body.

    @grokys
    grokys committed Nov 1, 2018
    Copy the full SHA
    b724525 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Implement posting PR comments.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    d296739 View commit details
    Browse the repository at this point in the history

  2. Disable comment view while submitting.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    0b91c87 View commit details
    Browse the repository at this point in the history

  3. Jiggled the comment thread hierachy a little. 

    Removed `Comments` from `ICommentThreadViewModel` beacuse the comments may be of different types.
    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    1200c4c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feature/pr-conversation

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    057c4e4 View commit details
    Browse the repository at this point in the history

  5. Fix up comment view models after merge.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    fe66df5 View commit details
    Browse the repository at this point in the history

  6. Correctly add new comments.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    a8d4da6 View commit details
    Browse the repository at this point in the history

  7. Make PR conversation tool windows multi-instance.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    d246ad2 View commit details
    Browse the repository at this point in the history

  8. Fix UI for closed PRs.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    6165f30 View commit details
    Browse the repository at this point in the history

  9. Display commit count.

    @grokys
    grokys committed Nov 5, 2018
    Copy the full SHA
    996aac3 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. Implement closing/reopening a PR. 

    This state is not synced with the PR details pane or the PR list currently though.
    @grokys
    grokys committed Nov 8, 2018
    Copy the full SHA
    6da33e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. Merge branch 'master' into feature/pr-conversation

    @grokys
    grokys committed Nov 9, 2018
    Copy the full SHA
    c3f9778 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Implemented edit/delete of comments.

    @grokys
    grokys committed Nov 14, 2018
    Copy the full SHA
    1308c0e View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2018

  1. Append "commented" after author name

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    6e88e35 View commit details
    Browse the repository at this point in the history

  2. Tweak header spacing

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    8697cb7 View commit details
    Browse the repository at this point in the history

  3. Make it boxy

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    624b5be View commit details
    Browse the repository at this point in the history

  4. Space it out a bit

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    d7d5969 View commit details
    Browse the repository at this point in the history

  5. More indenting and layout madness

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    d12b441 View commit details
    Browse the repository at this point in the history

  6. Lighten up the commit octicon

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    a03c85f View commit details
    Browse the repository at this point in the history

  7. Indent comment body

    @donokuda
    donokuda committed Nov 16, 2018
    Copy the full SHA
    aeb7c45 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Nudge things around

    @donokuda
    donokuda committed Nov 19, 2018
    Copy the full SHA
    b508e6a View commit details
    Browse the repository at this point in the history

  2. Standardizing all the spacing

    @donokuda
    donokuda committed Nov 19, 2018
    Copy the full SHA
    39d0b5f View commit details
    Browse the repository at this point in the history

  3. Adjust top margin

    @donokuda
    donokuda committed Nov 19, 2018
    Copy the full SHA
    b317753 View commit details
    Browse the repository at this point in the history

  4. Adjust vertical margins for reply prompt box

    @donokuda
    donokuda committed Nov 19, 2018
    Copy the full SHA
    7ebcfb9 View commit details
    Browse the repository at this point in the history

  5. nudge left margin

    @donokuda
    donokuda committed Nov 19, 2018
    Copy the full SHA
    815ee14 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2018

  1. Make things better for dark theme

    @donokuda
    donokuda committed Nov 20, 2018
    Copy the full SHA
    7535c64 View commit details
    Browse the repository at this point in the history

  2. Update separator colors

    @donokuda
    donokuda committed Nov 20, 2018
    Copy the full SHA
    1d57ce8 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2018

  1. Merge pull request #2070 from github/donokuda/polish-conversation-view 

    Begin polish for conversation view
    @grokys
    grokys committed Nov 22, 2018
    Copy the full SHA
    8340942 View commit details
    Browse the repository at this point in the history

  2. Finish off display of commit list w/caption.

    @grokys
    grokys committed Nov 22, 2018
    Copy the full SHA
    7b6a032 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2018

  1. Theming

    @donokuda
    donokuda committed Dec 11, 2018
    Copy the full SHA
    5308404 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2019

  1. Merge branch 'master' into feature/pr-conversation

    @grokys
    grokys committed Jan 17, 2019
    Copy the full SHA
    01676fe View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. Start styling the top comment

    @donokuda
    donokuda committed Jan 25, 2019
    Copy the full SHA
    ed0b3a4 View commit details
    Browse the repository at this point in the history

  2. Octicon in a circle yaaaaaa

    @donokuda
    donokuda committed Jan 25, 2019
    Copy the full SHA
    448ccac View commit details
    Browse the repository at this point in the history

  3. Tweak layout for commit list

    @donokuda
    donokuda committed Jan 25, 2019
    Copy the full SHA
    3ca7340 View commit details
    Browse the repository at this point in the history

  4. Decrease the size of the avatar

    @donokuda
    donokuda committed Jan 25, 2019
    Copy the full SHA
    2ae522c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Adjust padding

    @donokuda
    donokuda committed Jan 26, 2019
    Copy the full SHA
    4edf726 View commit details
    Browse the repository at this point in the history

  2. lol at least i tried

    @donokuda
    donokuda committed Jan 26, 2019
    Copy the full SHA
    6ac2d95 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Octicon timeline theming

    @donokuda
    donokuda committed Feb 5, 2019
    Copy the full SHA
    8f327c2 View commit details
    Browse the repository at this point in the history

  2. Let's not be too bold, now

    @donokuda
    donokuda committed Feb 5, 2019
    Copy the full SHA
    dc8a865 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature/pr-conversation

    @grokys
    grokys committed Feb 5, 2019
    Copy the full SHA
    5be7e2f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/pr-conversation' into donokuda/pr-polish

    @grokys
    grokys committed Feb 5, 2019
    Copy the full SHA
    72fb28b View commit details
    Browse the repository at this point in the history

  5. Fake it

    @donokuda
    donokuda committed Feb 5, 2019
    Copy the full SHA
    e307b36 View commit details
    Browse the repository at this point in the history

  6. Remove the description section

    @donokuda
    donokuda committed Feb 5, 2019
    Copy the full SHA
    d3caa17 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Refactored comment views. 

    Use a different view for comments in the conversation view and inline comments.
    @grokys
    grokys committed Feb 6, 2019
    Copy the full SHA
    abb4661 View commit details
    Browse the repository at this point in the history

  2. Move around conversation button

    @donokuda
    donokuda committed Feb 6, 2019
    Copy the full SHA
    a28d75a View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Record # of PR conversation views opened.

    @grokys
    grokys committed Feb 7, 2019
    Copy the full SHA
    b1b49a3 View commit details
    Browse the repository at this point in the history

  2. Always leave a note

    @donokuda
    donokuda committed Feb 7, 2019
    Copy the full SHA
    e10d6fb View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2019

  1. Hook up "View conversation" in PR details pane.

    @grokys
    grokys committed Feb 8, 2019
    Copy the full SHA
    84dd7ff View commit details
    Browse the repository at this point in the history

  2. Merge branch 'donokuda/pr-pane' into feature/pr-conversation

    @grokys
    grokys committed Feb 8, 2019
    Copy the full SHA
    08bfdc9 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2019

  1. Limit to 100 repos per org (fix bad merge)

    @jcansdale
    jcansdale committed Feb 12, 2019
    Copy the full SHA
    d8cf315 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2019

  1. Stub out comment count and view on github links

    @donokuda
    donokuda committed Feb 13, 2019
    Copy the full SHA
    d05a0ce View commit details
    Browse the repository at this point in the history

  2. Add comment octicon and leave some notes around

    @donokuda
    donokuda committed Feb 13, 2019
    Copy the full SHA
    8e42868 View commit details
    Browse the repository at this point in the history

  3. Add back in the description section

    @donokuda
    donokuda committed Feb 13, 2019
    Copy the full SHA
    4bdfa13 View commit details
    Browse the repository at this point in the history

  4. Bump spacing

    @donokuda
    donokuda committed Feb 13, 2019
    Copy the full SHA
    c8579c8 View commit details
    Browse the repository at this point in the history

  5. Collapse sections

    @donokuda
    donokuda committed Feb 13, 2019
    Copy the full SHA
    5958982 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2019

  1. Hook up "View on GitHub" link

    @jcansdale
    jcansdale committed Feb 19, 2019
    Copy the full SHA
    5702cb3 View commit details
    Browse the repository at this point in the history

  2. Show number of comments on OpenConversation button

    @jcansdale
    jcansdale committed Feb 19, 2019
    Copy the full SHA
    e504484 View commit details
    Browse the repository at this point in the history

  3. Don't collapse Reviewers or Checks sections 

    The Reviewers section contains an `Add your review` button which I
don't think should be hidden by default.
The Checks section is the only place where build status is surfaced and
contains a link to Details for each build.
    @jcansdale
    jcansdale committed Feb 19, 2019
    Copy the full SHA
    ae6935a View commit details
    Browse the repository at this point in the history

  4. Set the pull request WebUrl and OpenOnGitHub 

    Make hash-link at top pull request page open on GitHub.
    @jcansdale
    jcansdale committed Feb 19, 2019
    Copy the full SHA
    17f3f93 View commit details
    Browse the repository at this point in the history

  5. Allow pull request title to wrap

    @jcansdale
    jcansdale committed Feb 19, 2019
    Copy the full SHA
    3f43625 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2019

  1. Merge pull request #2229 from github/donokuda/moving-some-cheese 

    Add pull request comment count link and add back in description section
    @jcansdale
    jcansdale committed Feb 20, 2019
    Copy the full SHA
    abce76d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/pr-conversation

    @jcansdale
    jcansdale committed Feb 20, 2019
    Copy the full SHA
    a8df4e6 View commit details
    Browse the repository at this point in the history

  3. Disabling automatic focus

    @StanleyGoldman
    StanleyGoldman committed Feb 20, 2019
    Copy the full SHA
    fd9eab5 View commit details
    Browse the repository at this point in the history

  4. Removing left over event handler

    @StanleyGoldman
    StanleyGoldman committed Feb 20, 2019
    Copy the full SHA
    f144895 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2019

  1. Shouldn't need the nuget package for octokit.graphql anymore

    @StanleyGoldman
    StanleyGoldman committed Feb 21, 2019
    Copy the full SHA
    89f33ac View commit details
    Browse the repository at this point in the history