Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Remove the experimental PR file margin #2408

Merged
merged 8 commits into from Mar 17, 2020

Conversation

jcansdale
Copy link
Collaborator

@jcansdale jcansdale commented Aug 14, 2019

The experimental PR file margin was used to show/hide inline comments on live code. Since this facility is no longer being developed, there is no reason for the margin to still exist. Having it there unnecessarily loads GitHub assemblies when the editor is used.

What this PR does

  • Remove the EditorComments option
  • Remove all PullRequestFileMargin related files
  • Remove checkbox from experimental options UI

@jcansdale jcansdale requested a review from a user March 15, 2020 18:51
@jcansdale jcansdale merged commit ab1e2b1 into master Mar 17, 2020
@jcansdale jcansdale deleted the fixes/remove-experimental-PR-file-margin branch March 17, 2020 13:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants