This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Added null check in IsLastItemInContainerConverter. #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#503 is a crash that seems to occur here. Can't reproduce locally but there's only so much that can cause an NRE in this method so try to avoid it in future.
| { | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
Indentation seems heavily screwed up here.
Also, this is probably enough:
return ic != null ? ic.ItemContainerGenerator.IndexFromContainer(item) == ic.Items.Count - 1 : false;
If ic is not null than Items won't be null either (I peeked, it's created in the getter).
| { | ||
| return false; | ||
| } | ||
| return ic?.ItemContainerGenerator.IndexFromContainer(item) == ic.Items.Count - 1; |
There was a problem hiding this comment.
Won't it still crash on the right-hand side in ic.Items.Count?
|
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#503 is a crash that seems to occur here. Can't reproduce locally but there's only so much that can cause an NRE in this method so try to avoid it in future.