Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ci.yml workflow for clarity #20

Merged
merged 3 commits into from Jun 16, 2023
Merged

Update ci.yml workflow for clarity #20

merged 3 commits into from Jun 16, 2023

Conversation

khiga8
Copy link
Contributor

@khiga8 khiga8 commented Jun 16, 2023 •
edited

This PR updates the workflow file to make the job names more clear.

I am also updating the dispatch events to:

  push:
    branches: ["main"]
  workflow_dispatch:
  pull_request:

@khiga8 khiga8 requested a review from a team as a code owner June 16, 2023 15:13
@khiga8 khiga8 marked this pull request as draft June 16, 2023 15:23
@khiga8 khiga8 marked this pull request as ready for review June 16, 2023 15:32
@khiga8 khiga8 assigned khiga8 and unassigned khiga8 Jun 16, 2023
smockle
smockle approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@smockle smockle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this on Slack; kudos @khiga8 for looking into the right events!

@khiga8 khiga8 merged commit d0a0e00 into main Jun 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smockle smockle smockle approved these changes

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khiga8 @smockle