Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-p26g-97m4-6q7c] Eclipse Jetty's cookie parsing of quoted values can exfiltrate values from other cookies #2404

Conversation

jeffalder
Copy link

Updates

  • Affected products

Comments
Similar fix as #2393; The correct version is already specified in the details markdown.

@github
Copy link
Collaborator

github commented Jun 13, 2023

Hi there @jmcc0nn3ll! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to jeffalder/advisory-improvement-2404 June 13, 2023 17:25
@jeffalder
Copy link
Author

@darakian - Just to be clear compared to #2393, can you help me understand what I should do differently? Should I try to update jetty-server's advisory directly?

https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.51.v20230217 - here's the tag that shows that the CVE was fixed in that release

jetty/jetty.project@jetty-9.4.50.v20221201...jetty-9.4.51.v20230217 - here's the diff from the previous release

jetty/jetty.project#9352 - here's the PR that's mentioned in this advisory

https://central.sonatype.com/artifact/org.eclipse.jetty/jetty-server/9.4.51.v20230217 - here's the artifact from Maven Central.

@darakian
Copy link
Contributor

darakian commented Jun 13, 2023

@jeffalder this is perfect from my perspective. Having a release tag which links back to the root issue is 👍
I just wanted to make the point in the last PR that we need to validate things before we accept them. Search through some of the closed and not merged PRs in this repo and I think you'll get what I mean 😉

@advisory-database advisory-database bot merged commit c401ad1 into jeffalder/advisory-improvement-2404 Jun 13, 2023
2 checks passed
@advisory-database advisory-database bot deleted the jeffalder-GHSA-p26g-97m4-6q7c branch June 13, 2023 22:44
@advisory-database
Copy link
Contributor

Hi @jeffalder! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

@jmcc0nn3ll
Copy link

I see; the issue is there is some tooling that is not picking up the nuance of 9.4.51 with that v## date at the end. Do I have that correct?

@darakian
Copy link
Contributor

I suppose you can put it that way. The source advisory that we ingested didn't reference the v## date at the end and it seems that during manual review of the advisory we missed that.

@jmcc0nn3ll
Copy link

Sorry, just a bit confused with the process here since I got notified of it. I have no issue with this change or the other in #2393, it is a good clarification, and we'll try and keep it in future CVEs. Do you know if I need to do anything here?

cheers,
Jesse

@darakian
Copy link
Contributor

All good. We have an automated system to ping authors so they're at least in the loop about changes to how the global version of their advisory is being altered. Nothing needed on your end 😃

@jmcc0nn3ll
Copy link

Perfect, thanks for keeping us in the loop; I appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants