generated from actions/typescript-action
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameter Support #146
Merged
Merged
Parameter Support #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameter Support
While investigating #144, it was discovered that the
prefix_only
option is not working properly. I did a lot of research and testing into this and determined that the path forward is deprecation of this input option for a few reasons:.deploy
is not the very start of the command will lead to some pretty unexpected behaviorI took a look at "why" we would want to use
prefix_only
in the first place and the overwhelming reason was to try and pass parameters into issueops commands in a fairly "hacky" way. Rather than doing so in a "hacky" way, I determined that the best path forward would be to deprecateprefix_only: false
invocations and make parameters a native feature of this Action.New Inputs
This Pull Request introduces a new Action input and Action output:
param_separator
- Designates a special character (or string) to separate the IssueOps command from an arbitrary string of parametersparams
- A raw string of the detected parameters saved to the output of thebranch-deploy
Action workflowFurther documentation on how parameters work can be found here
Resolves: #144