Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks mode input #241

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Add checks mode input #241

merged 3 commits into from
Feb 17, 2024

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented Feb 15, 2024

Closes #73

Uses the approach suggested in the issue itself.

@GrantBirki
Copy link
Member

@Ugzuzg Have you tested out all these changes in a project somewhere and confirmed that it is working as expected?

@GrantBirki
Copy link
Member

@Ugzuzg I don't think this quite works. Here is how I tested for you to replicate:

  1. I set checks: required in my Actions config. I confirmed this setting was enabled by viewing my Actions logs

  2. I created a required CI check on my pull request

    image

  3. I attempted to deploy that branch

  4. The deployment failed even though the only failing CI check was one that was not required

    image

@Ugzuzg Ugzuzg force-pushed the feat/required-checks branch 3 times, most recently from 629f689 to b895cb6 Compare February 17, 2024 09:07
@Ugzuzg
Copy link
Contributor Author

Ugzuzg commented Feb 17, 2024

Thanks for pointing that out! Here's the working version: https://github.com/Ugzuzg/actions-sandbox/pull/2

I didn't notice that checks needed to be manually read and passed to the function.

@GrantBirki GrantBirki added the enhancement New feature or request label Feb 17, 2024
@GrantBirki GrantBirki merged commit 78f0f04 into github:main Feb 17, 2024
4 checks passed
@GrantBirki GrantBirki mentioned this pull request Feb 17, 2024
@Ugzuzg Ugzuzg deleted the feat/required-checks branch February 17, 2024 21:42
@GrantBirki
Copy link
Member

@Ugzuzg your changes are live in the following pre-release! Go ahead and give it a try and I'll make it the latest release within the next week for the public to use 🎉

https://github.com/github/branch-deploy/releases/tag/v9.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: does not observe required checks
2 participants