Restructure individual license pages, added styles to improve alignment #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great to me. Wonderful! Only quibble is I'm not sure the License Text heading is needed. Will leave this open to collect other feedback since it is a pretty big change to the individual license pages. |
|
Ok sounds reasonable but my thought process is that the visitor should feel more confident in what license text the copy button is referring to since there is the description text and the rules before it. |
|
Really like this change, and agree with @mlinksva that the license text should be self-explanatory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #355 and an update to #382 (which essentially makes it obsolete)
Always wonderful visual:
