Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strikethrough extension is underspecified #74

Open
srawlins opened this issue Jan 5, 2018 · 1 comment
Open

Strikethrough extension is underspecified #74

srawlins opened this issue Jan 5, 2018 · 1 comment

Comments

@srawlins
Copy link

srawlins commented Jan 5, 2018

As far as Markdown-enabled textboxes on GitHub are concerned, the Strikethrough extension is underspecified. In general, it seems to have some of the same left-flanking/right-flanking rules. I haven't looked at the code yet, but here are some examples. According to the spec:

Strikethrough text is any text wrapped in tildes (~).

However, we can find a number of counter examples:

A "right-flanking" ~ cannot open text, nor can a "left-flanking" ~ close strikethrough

Markdown input as rendered by GitHub
~ text~ ~ text~
~text ~ ~text ~

The "multiple of 3" combined delimiter rule seems to apply

From the last sentence of rule #9.

Markdown input as rendered by GitHub
~foo~~bar ~foo~~bar
~~foo~bar ~~foo~bar

The shorter span rule seems to apply

From rule #16

Markdown input as rendered by GitHub
~~foo ~~bar~~ ~~foo bar

The "links group more tightly" rule seems to apply

From rule #17

Markdown input as rendered by GitHub
~[foo~](bar) ~foo~

I'd be happy to send a PR.

@puzrin
Copy link

puzrin commented Jul 16, 2018

Probably, partially solved by #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants