Strikethrough does not work midword like on GitHub

[not-my-profile]

GitHub renders ~~foo~~bar as foobar and foo~~bar~~ as foobar.

pulldown-cmark however doesn't recognize both strikethroughs:

$ echo '~~foo~~bar' | cargo run  -- -S
<p>~~foo~~bar</p>
$ echo 'foo~~bar~~' | cargo run  -- -S
<p>foo~~bar~~</p>

Unfortunately the GFM spec doesn't say much about strikethroughs (see github/cmark-gfm#74), but we could of course still be consistent with the established GitHub rendering.

[marcusklaas]

Hi! Thanks for reporting this, and my apologies for only getting back to you now.

I think we certainly would like to be consistent with GitHub where we can, but to me it's not entirely clear whether strikethrough behavior is merely underspecified, or that the GitHub implementation of the spec is incorrect, especially since the behavior is not consistent with that of other text modifiers.

As long as we are consistent with the latest spec, I am very open to persuasion on this issue.

[SilverBut]

Considering the strikethrough discussion in the standard have not made much process for almost 10 years and the GFM is surely popular, maybe we should consider following GFM by making strikethrough works in midword.

Also, for CJK and some other languages, words are not split by space. Instead, characters in those languages will group into words by their meaning. Japanese wikipedia gave a good example:

(Translate: Texts are partially removed and new text inserted like this)

Thus, making strikethrough works in midword is useful for CJK users, and not affecting other people meanwhile.

cc @marcusklaas if you are still following this issue

[Martin1887]

Good point, I will work on this soon.