Footnotes #64
Merged
Footnotes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love some review from @vmg and/or @charliesome. |
Merged
vmg
reviewed
Nov 13, 2017
src/commonmark.c
Outdated
| @@ -162,6 +162,8 @@ static cmark_node *get_containing_block(cmark_node *node) { | |||
| return NULL; | |||
| } | |||
|
|
|||
| static unsigned int footnote_ix; | |||
There was a problem hiding this comment.
Proooobably not fine. 😄
It seems like this single variable stops the whole library from being threadsafe. Can we give this some more thought? Surely the footnote index can fit in one of the many state structs we're already passing around.
|
@kivikakk - What is the timeline for this footnote extension to be enabled in GitHub or for gists? |
|
There are no plans to enable the extension on GitHub.com or in gists. This is for Pages only. |
|
@kivikakk - Needless to say, this makes me really sad, but I really appreciate your definitive answer. |
talum
pushed a commit
that referenced
this pull request
Sep 14, 2021
* Add baseline test * Some preliminary work. * cont'd * Add footnote reference * Start postprocessing * MVP: tests pass * commonmark footnote out * Factor out reference/footnote maps * fix a memory leak & some asserts * We don't assert/check snprintf elsewhere * Remove bad linear search, extend test case * cleanup * man page update * add footnotes as option * bugfix (found in comrak first!) * Shift static var into renderer struct
|
@metasean Good news: Footnotes now supported in Markdown fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56. Adds support for footnotes to
cmark-gfm. This is a key requirement of being able to be used where Kramdown is; for instance, Kramdown is the default Markdown renderer in GitHub Pages.This PR does the following:
To-do:
fix thewhatever it's finestatic unsigned int ix;hack incommonmark.csnprintfresults and turn them into asserts