Skip to content

Commit

Permalink
Just check the number of locations
Browse files Browse the repository at this point in the history
Only tests the property we are looking for and avoids problems with
different cross-platform behavior.
  • Loading branch information
henrymercer committed Mar 24, 2023
1 parent c8935d5 commit 329c022
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions .github/workflows/__diagnostics-export.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions pr-checks/checks/diagnostics-export.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,6 @@ steps:
if (n.locations.length !== 1) {
core.setFailed(`Expected the status page diagnostic to have exactly 1 location, but found ${n.locations.length}.`);
}
const actualUri = n.locations[0].physicalLocation?.artifactLocation?.uri
if (actualUri !== '/path/to/file') {
core.setFailed(`Expected the status page diagnostic to have a location with the URI '/path/to/file', but found '${actualUri}'.`);
}
}
const sarif = JSON.parse(fs.readFileSync(process.env['SARIF_PATH'], 'utf8'));
Expand Down

0 comments on commit 329c022

Please sign in to comment.