Skip to content

Commit

Permalink
Comment why we don't run multiple autobuilders for other languages
Browse files Browse the repository at this point in the history
  • Loading branch information
henrymercer committed Sep 12, 2022
1 parent 40e0374 commit bde5694
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
7 changes: 7 additions & 0 deletions lib/autobuild.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/autobuild.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions src/autobuild.ts
Expand Up @@ -72,6 +72,13 @@ export async function determineAutobuildLanguages(

logger.debug(`Will autobuild ${languages.join(" and ")}.`);

// In general the autobuilders for other traced languages may conflict with
// each other. Therefore if a user has requested more than one non-Go traced
// language, we ask for manual build steps.
// Matrixing the build would also work, but that would change the SARIF
// categories, potentially leading to a "stale tips" situation where alerts
// that should be fixed remain on a repo since they are linked to SARIF
// categories that are no longer updated.
if (autobuildLanguagesNoGo.length > 1) {
logger.warning(
`We will only automatically build ${languages.join(
Expand Down

0 comments on commit bde5694

Please sign in to comment.