Merge pull request #843 from github/wait-for-processing-by-default

Start waiting for processing by default.
github · Dec 13, 2021 · eacec36 · eacec36
2 parents 716b598 + e0e2abc
commit eacec36
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ No user facing changes.
 ## 1.0.26 - 10 Dec 2021
 
 - Update default CodeQL bundle version to 2.7.3. [#842](https://github.com/github/codeql-action/pull/842)
+- The `analyze` and `upload-sarif` actions will now wait up to 2 minutes for processing to complete after they have uploaded the results so they can report any processing errors that occurred. This behavior can be disabled by setting the `wait-for-processing` action input to `"false"`.
 
 ## 1.0.25 - 06 Dec 2021
 

diff --git a/analyze/action.yml b/analyze/action.yml
@@ -55,7 +55,7 @@ inputs:
   wait-for-processing:
     description: If true, the Action will wait for the uploaded SARIF to be processed before completing.
     required: true
-    default: "false"
+    default: "true"
   token:
     default: ${{ github.token }}
   matrix:

diff --git a/upload-sarif/action.yml b/upload-sarif/action.yml
@@ -23,7 +23,7 @@ inputs:
   wait-for-processing:
     description: If true, the Action will wait for the uploaded SARIF to be processed before completing.
     required: true
-    default: "false"
+    default: "true"
 runs:
   using: 'node12'
   main: '../lib/upload-sarif-action.js'