Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid use of rmdir #1095

Merged
merged 1 commit into from Jun 14, 2022
Merged

Avoid use of rmdir #1095

merged 1 commit into from Jun 14, 2022

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Jun 13, 2022 •
edited

This is a deprecated method on node v16.

Fixes #1091

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner June 13, 2022 22:35
@aeisenberg
Avoid use of rmdir
f7c46e5 
This is a deprecated method on node v16.
henrymercer
henrymercer approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change we will no longer retry deleting the directory. However this shouldn't be problematic since the Actions runtime environment isn't affected by the Windows ATP issues, and the runner no longer exists.

@aeisenberg
Copy link
Contributor Author

Yes, it's unclear if we ever actually needed it in the past.

@aeisenberg aeisenberg merged commit 29a2159 into main Jun 14, 2022
@aeisenberg aeisenberg deleted the aeisenberg/use-del branch June 14, 2022 00:55
This was referenced Jun 21, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

codeql-action/analyze@v2 - Deprecation warning from Node on use of fs.rmdir
2 participants
@aeisenberg @henrymercer