Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove distrust of GITHUB_ACTION_REF for local actions #1174

Merged
merged 1 commit into from Aug 10, 2022
Merged

Remove distrust of GITHUB_ACTION_REF for local actions #1174

merged 1 commit into from Aug 10, 2022

Conversation

edoardopirovano
Copy link
Contributor

The linked issue has been fixed (for a long enough time to be in every supported GHES version), so let's remove this bit of logic.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@edoardopirovano edoardopirovano requested a review from a team as a code owner August 10, 2022 08:41
robertbrignull
robertbrignull approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up

@edoardopirovano edoardopirovano merged commit c7db5d9 into main Aug 10, 2022
@edoardopirovano edoardopirovano deleted the edoardo/remove-workaround branch August 10, 2022 10:50
This was referenced Aug 17, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edoardopirovano @robertbrignull