Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the min version for code scanning config in the cli #1318

Merged
merged 1 commit into from Oct 24, 2022

Conversation

aeisenberg
Copy link
Contributor

2.11.1 has a fix in it for parsing query filters. Workflows using query filters will break if they are using syntax like:

- exclude:
      id: foo/bar

instead of

- exclude:
      - id: foo/bar

So, prevent users of CLI versions earlier than 2.11.1 from using the cli config parsing flag.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner October 21, 2022 19:46
henrymercer
henrymercer previously approved these changes Oct 24, 2022
2.11.1 has a fix in it for parsing query filters.
@aeisenberg aeisenberg changed the title Bumps the min version for code scanning config in the cli Bump the min version for code scanning config in the cli Oct 24, 2022
@aeisenberg aeisenberg merged commit de9f112 into main Oct 24, 2022
@aeisenberg aeisenberg deleted the aeisenberg/bump-min-version branch October 24, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants