Actions status report: Send testing_environment. #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
previously approved these changes
Oct 25, 2022
There was a problem hiding this comment.
I guess the main question for the reviewers is if the environment variable should be set again using the actions environment mechanism to preserve it for future steps.
I like this idea — it sounds like this would be one line of code that could prevent some headaches.
The testing environment is taken from the environment variable CODEQL_ACTION_TESTING_ENVIRONMENT.
criemen
force-pushed
the
criemen/datadog-tag
branch
from
78d9e75
to
bfcbb09
Compare
|
Rebased on top of main and added the call to |
henrymercer
previously approved these changes
Nov 1, 2022
Co-authored-by: Henry Mercer <henry.mercer@me.com>
henrymercer
approved these changes
Nov 1, 2022
This was referenced Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing environment is taken from the environment variable
CODEQL_ACTION_TESTING_ENVIRONMENT.I guess the main question for the reviewers is if the environment variable should be set again using the actions environment mechanism to preserve it for future steps.
But I think we get away with a top-level env block, or a per-job env entry that we can use.
CC @esbena
Merge / deployment checklist