Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable a controlled switchover between CodeQL releases #1475

Merged
merged 29 commits into from Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from 25 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
cdb9019
Support determining Dotcom CLI version from feature flags
henrymercer Jan 5, 2023
a6dff04
Ignore default version flags with invalid version numbers
henrymercer Jan 5, 2023
a76fe4f
Enable mapping from CLI version to bundle tag name
henrymercer Jan 6, 2023
bd2f52f
Move CodeQL setup to its own file
henrymercer Jan 9, 2023
c3be36f
Use new default version to set up CodeQL
henrymercer Jan 10, 2023
23d151d
Add test for using default version with no requested URL on Dotcom
henrymercer Jan 10, 2023
2f7b9a1
Differentiate `setupCodeql.setupCodeQL` from `codeql.setupCodeQL`
henrymercer Jan 11, 2023
e8c12e1
Add a debug log for the feature flag API response
henrymercer Jan 11, 2023
648838c
Allow using a `x.y.z-yyyymmdd` toolcache version for CLI `x.y.z`.
henrymercer Jan 12, 2023
1eeb9df
Remove dead code
henrymercer Jan 12, 2023
a89ad76
Expand note about defaults.json compatibility
henrymercer Jan 12, 2023
31c7ce1
Add doc describing CLI version marker files
henrymercer Jan 12, 2023
9578699
Merge branch 'main' into henrymercer/controlled-switchover
henrymercer Jan 12, 2023
28f827a
Add changelog notes
henrymercer Jan 12, 2023
c9b1be5
Bump version to 2.2.0
henrymercer Jan 12, 2023
c2e39e0
Cache explicitly requested bundles with their URL if possible
henrymercer Jan 12, 2023
33206d2
Include the bundle version in the toolcache version number
henrymercer Jan 12, 2023
0be20e5
Use the CLI version when caching the bundle in telemetry too
henrymercer Jan 12, 2023
12998b7
Convert logger call to debug
henrymercer Jan 13, 2023
13cdac3
Improve changelog notes
henrymercer Jan 13, 2023
eca06a5
Further improve changelog notes
henrymercer Jan 13, 2023
ac7e4d7
Improve changelog note some more
henrymercer Jan 16, 2023
115587a
Merge branch 'main' into henrymercer/controlled-switchover
henrymercer Jan 16, 2023
b660a38
Address review comments
henrymercer Jan 16, 2023
a5b44c1
Add a sentence on recommended practices for using the CLI
henrymercer Jan 16, 2023
5f1362d
Merge branch 'main' into henrymercer/controlled-switchover
henrymercer Jan 18, 2023
8a4abfd
Support `cli-version-x.y.z-pre.txt` marker files
henrymercer Jan 18, 2023
3d62f02
Update changelog note
henrymercer Jan 18, 2023
9012214
Merge branch 'main' into henrymercer/controlled-switchover
henrymercer Jan 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions CHANGELOG.md
Expand Up @@ -2,6 +2,20 @@

## [UNRELEASED]

- Improve stability when choosing the default version of CodeQL to use in code scanning workflow runs on Actions on GitHub.com [#1475](https://github.com/github/codeql-action/pull/1475).
- This change addresses customer reports of code scanning alerts on GitHub.com being closed and reopened during the rollout of new versions of CodeQL in the GitHub Actions [runner images](https://github.com/actions/runner-images).
- **No change is required for the majority of workflows**, including:
- Workflows on GitHub.com hosted runners using the latest version (`v2`) of the CodeQL Action.
- Workflows on GitHub.com hosted runners that are pinned to specific versions of the CodeQL Action from `v2.2.0` onwards.
- Workflows on GitHub Enterprise Server.
- **A change may be required** for workflows on GitHub.com hosted runners that are pinned to specific versions of the CodeQL Action before `v2.2.0` (e.g. `v2.1.32`):
- Previously, these workflows would obtain the latest version of CodeQL from the Actions runner image.
- Now, these workflows will download an older, compatible version of CodeQL from GitHub Releases. To use this older version, no change is required. To use the newest version of CodeQL, please update your workflows to reference the latest version of the CodeQL Action (`v2`).
- **Advanced users only**: Workflows that interact directly with the GitHub Actions runner image tool cache to find CodeQL, for example via the `@actions/tool-cache` npm package or direct access to the filesystem, should take into account the following internal layout changes:
- Previously, the tool cache was pre-populated with _one_ recent version of CodeQL. Now, it is pre-populated with _two_ recent versions of CodeQL.
- Previously, the CodeQL tools were located within the tool cache under a directory named after the release date, e.g. CodeQL 2.11.6 was located under `CodeQL/0.0.0-20221211/x64/codeql`. Now, the CodeQL tools are located under a directory named after the CodeQL CLI version number and release date, e.g. CodeQL 2.11.6 is now located under `CodeQL/2.11.6-20221211/x64/codeql`.

Where possible, we recommend downloading and managing the CodeQL CLI via the [CodeQL extension for the GitHub CLI](https://github.com/github/gh-codeql) or [GitHub Releases](https://github.com/github/codeql-cli-binaries/releases) rather than using the CodeQL tools from the runner image tool cache.
- Python automatic dependency installation will no longer fail for projects using Poetry that specify `virtualenvs.options.no-pip = true` in their `poetry.toml`. [#1431](https://github.com/github/codeql-action/pull/1431).

## 2.1.38 - 12 Jan 2023
Expand Down
241 changes: 7 additions & 234 deletions lib/codeql.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map

Large diffs are not rendered by default.