Skip the SARIF notification object workaround for CLIs that have fixed this bug #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrymercer
force-pushed
the
henrymercer/duplicate-diagnostics-fixed-in-cli
branch
from
e09243d
to
240c12b
Compare
henrymercer
force-pushed
the
henrymercer/duplicate-diagnostics-fixed-in-cli
branch
from
240c12b
to
3bba073
Compare
aeisenberg
reviewed
Apr 4, 2023
aeisenberg
approved these changes
Apr 4, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of the CodeQL CLI (2.12.6) contains a fix for the duplicate SARIF notification object bug in 2.12.5.
This PR updates the Action so it no longer applies the workaround to CodeQL CLI version 2.12.6 and later. We extend the integration tests to make sure we keep checking the workaround on 2.12.5.
Merge / deployment checklist