Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract semantic CLI version from URL when requesting specific tools #1682

merged 4 commits into from
May 18, 2023


Copy link

@henrymercer henrymercer commented May 16, 2023

This PR prepares the Action for migrating the CodeQL Bundle to be versioned using a semantic version (e.g. codeql-bundle-v1.2.3). Most of the work is already done, but this PR makes a small improvement to ensure we can look up CLIs requested via tools in the tool cache before downloading them. Specifically, we populate cliVersion when we can recognize that the requested CodeQL Bundle tag uses a semantic version. The rest of the changes here are pulling out shared test utilities so we can write more specific CodeQL setup tests in setup-codeql.test.ts.

There's scope for some cleanup and refactoring here now we're migrating the bundle version to semver, but this will be easier to do once this change is fully rolled out.

We also add a changelog note to notify customers about the change to the way that bundles will be tagged for future CodeQL versions.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner May 16, 2023 17:41
angelapwen previously approved these changes May 16, 2023
Copy link

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for doing some of the testing refactoring too 😸

angelapwen previously approved these changes May 17, 2023 Outdated Show resolved Hide resolved
@henrymercer henrymercer merged commit 6cfb483 into main May 18, 2023
325 checks passed
@henrymercer henrymercer deleted the henrymercer/semver-bundles branch May 18, 2023 10:32
@github-actions github-actions bot mentioned this pull request May 24, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants