Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify toolcache version number for semantically versioned bundles #1832

Merged
merged 2 commits into from Aug 10, 2023

Conversation

henrymercer
Copy link
Contributor

When we download a semantically versioned bundle, version it in the toolcache using just the CLI version number, 2.14.0, since for semantically versioned bundles that's sufficient information to look them up in the toolcache from a tools URL.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner August 10, 2023 13:40
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@henrymercer henrymercer merged commit 6ed1ccd into main Aug 10, 2023
344 checks passed
@henrymercer henrymercer deleted the henrymercer/nicer-toolcache-version-numbers branch August 10, 2023 14:32
@github-actions github-actions bot mentioned this pull request Aug 14, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants