Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use actions/checkout@v4 in test helper #1898

Merged
merged 2 commits into from Sep 28, 2023
Merged

Use actions/checkout@v4 in test helper #1898

merged 2 commits into from Sep 28, 2023

Conversation

Panquesito7
Copy link
Contributor

@Panquesito7 Panquesito7 commented Sep 21, 2023 •
edited by angelapwen

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@Panquesito7 Panquesito7 requested a review from a team as a code owner September 21, 2023 04:29
angelapwen
angelapwen previously approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@angelapwen angelapwen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @Panquesito7 ✨ Looks like we missed this test helper when we bumped our workflows in #1865!

@angelapwen angelapwen changed the title Use actions/checkout@v4 Use actions/checkout@v4 in test helper Sep 25, 2023
@angelapwen angelapwen enabled auto-merge (squash) September 25, 2023 19:24
@angelapwen
Copy link
Contributor

Oh, you'll want to run npm run build to create the autogenerated transpilation files that are missing.

@Panquesito7
Copy link
Contributor Author

Oh, you'll want to run npm run build to create the autogenerated transpilation files that are missing.

Thanks! Will do that immediately. 🙂

auto-merge was automatically disabled September 28, 2023 20:30

Head branch was pushed to by a user without write access

@adityasharad adityasharad merged commit a370ce3 into github:main Sep 28, 2023
384 checks passed
@Panquesito7 Panquesito7 deleted the checkout_v4 branch October 3, 2023 00:23
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasharad adityasharad adityasharad approved these changes

@angelapwen angelapwen angelapwen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Panquesito7 @angelapwen @adityasharad