Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum CodeQL version to 2.10.5 #1907

Merged
merged 10 commits into from
Sep 27, 2023

Conversation

henrymercer
Copy link
Contributor

Now that the 2.9.* series is deprecated, we can remove tech debt in the Action and update our testing matrix to improve our test coverage against the latest versions of CodeQL.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner September 27, 2023 15:25
aeisenberg
aeisenberg previously approved these changes Sep 27, 2023
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.

Can you also take a look at the individual checks to see if any of them can start testing against more versions. For example, pr-checks/checks/packaging-config-inputs-js.yml says that it works against recent CLIs, but now, I think it is available in all CLIs that are still supported.

This could happen separately.

And, only if you think it would be helpful, you could add a section in the CONTRIBUTING.md on the different steps to take when removing support for an old CLI.

@henrymercer
Copy link
Contributor Author

Can you also take a look at the individual checks to see if any of them can start testing against more versions. For example, pr-checks/checks/packaging-config-inputs-js.yml says that it works against recent CLIs, but now, I think it is available in all CLIs that are still supported.

I have a separate plan for this — we are currently running too many CI jobs on each PR, which causes friction both internally when jobs fail for transient reasons and externally, because API rate limits can prevent contributors from being able to run the checks. Specifically, I'd like to start testing particularly old CLIs on a nightly basis and on the release branches instead of on main.

And, only if you think it would be helpful, you could add a section in the CONTRIBUTING.md on the different steps to take when removing support for an old CLI.

Good idea, I'll do this.

Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@henrymercer henrymercer merged commit e7a6fa9 into main Sep 27, 2023
384 checks passed
@henrymercer henrymercer deleted the henrymercer/deprecate-codeql-2.9 branch September 27, 2023 20:36
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants