Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: add deptrace pr-checks #1964

Merged
merged 7 commits into from Oct 25, 2023
Merged

C++: add deptrace pr-checks #1964

merged 7 commits into from Oct 25, 2023

Conversation

redsun82
Copy link
Contributor

@redsun82 redsun82 commented Oct 23, 2023 •
edited

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@redsun82 redsun82 force-pushed the redsun82/cpp-deptrace-pr-checks branch from 9c3ff35 to d53a59d Compare October 23, 2023 08:58
@redsun82 redsun82 closed this Oct 25, 2023
@redsun82 redsun82 reopened this Oct 25, 2023
@redsun82 redsun82 marked this pull request as ready for review October 25, 2023 09:59
@redsun82 redsun82 requested a review from a team as a code owner October 25, 2023 09:59
henrymercer
henrymercer reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor comments and suggestions for clarity, but this looks good!

pr-checks/checks/cpp-deptrace-disabled.yml Outdated Show resolved Hide resolved
pr-checks/checks/cpp-deptrace-disabled.yml Outdated Show resolved Hide resolved
pr-checks/checks/cpp-deptrace-disabled.yml Outdated Show resolved Hide resolved
pr-checks/checks/cpp-deptrace-enabled-on-macos.yml Outdated Show resolved Hide resolved
pr-checks/checks/cpp-deptrace-enabled-on-macos.yml Outdated Show resolved Hide resolved
pr-checks/checks/cpp-deptrace-enabled.yml Outdated Show resolved Hide resolved
pr-checks/checks/cpp-deptrace-enabled.yml Outdated Show resolved Hide resolved
redsun82 and others added 2 commits October 25, 2023 12:23
@redsun82 @henrymercer
Apply suggestions from code review
e3f5f83 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@redsun82
Sync PR checks
f1b64d8
@redsun82 redsun82 merged commit edb8265 into main Oct 25, 2023
337 checks passed
@redsun82 redsun82 deleted the redsun82/cpp-deptrace-pr-checks branch October 25, 2023 12:54
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@redsun82 @henrymercer