Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error in Update release branch workflow #2051

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Fix type error in Update release branch workflow #2051

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
658e3c6
Fix type error
angelapwen Dec 21, 2023
0be9290
Typecast `OLDEST_SUPPORTED_MAJOR_VERSION` when defined
angelapwen Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/release-branches/release-branches.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def main():
if consider_backports:
for i in range(int(major_version.strip("v"))-1, 0, -1):
branch_name = f"releases/v{i}"
if i >= OLDEST_SUPPORTED_MAJOR_VERSION:
if i >= int(OLDEST_SUPPORTED_MAJOR_VERSION):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only use of this variable so it works; the more durable option would be to typecast at the definition of OLDEST_SUPPORTED_MAJOR_VERSION.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's fair — I had thought it might be easier to explicitly cast when used but I guess we'd always be using it as an int. I'll update.

backport_target_branches.append(branch_name)

f.write("backport_target_branches="+json.dumps(backport_target_branches)+"\n")
Expand Down