Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more configuration errors #2237

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

henrymercer
Copy link
Contributor

Add configuration errors for:

  • Hitting API rate limits
  • Deleting the branch before uploading SARIF to it, or specifying an invalid ref to start with
  • Specifying an unsupported build mode

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner April 12, 2024 17:34
export function wrapApiConfigurationError(e: unknown) {
if (isHTTPError(e)) {
if (
e.message.includes("API rate limit exceeded for site ID installation") ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern with this one is that we have a bug in the action where we are inadvertently causing rate limits for the repository. I feel like this has happened in the past.

Is this error for an org/user or is it specific to the repository/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time the rate limit hits are legitimate, so this creates a level of noise that means we have a bunch of false positive monitor pings or have to raise our thresholds and miss genuine failures. My recommendation is we avoid the possibility of a bug in the Action as part of our monitoring for significant changes in configuration errors, which is intended to capture these errors that are noisy, but have signal in large numbers.

@henrymercer henrymercer merged commit d30d1ca into main Apr 12, 2024
315 checks passed
@henrymercer henrymercer deleted the henrymercer/more-configuration-errors branch April 12, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants