Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid fingerprinting directories #479

Merged
merged 1 commit into from May 5, 2021
Merged

Avoid fingerprinting directories #479

merged 1 commit into from May 5, 2021

Conversation

aeisenberg
Copy link
Contributor

Fixes #478

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@aeisenberg aeisenberg force-pushed the aeisenberg/directory-fingerprint branch from 1405700 to f584f94 Compare May 5, 2021 20:39
chrisgavin
chrisgavin approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@chrisgavin chrisgavin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It makes sense to treat directories the same as non-existent files; we can't really compute a fingerprint for them.

@aeisenberg aeisenberg merged commit a7d3945 into main May 5, 2021
@aeisenberg aeisenberg deleted the aeisenberg/directory-fingerprint branch May 5, 2021 20:54
@github-actions github-actions bot mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisgavin chrisgavin chrisgavin approved these changes

@cbraynor cbraynor Awaiting requested review from cbraynor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fingerprinting in the upload-sarif action fails with directories
2 participants
@aeisenberg @chrisgavin