Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status reporting: fix codeql_version field name #992

Merged
merged 1 commit into from Mar 23, 2022
Merged

Status reporting: fix codeql_version field name #992

merged 1 commit into from Mar 23, 2022

Conversation

cklin
Copy link
Contributor

@cklin cklin commented Mar 23, 2022

This PR fixes the StatusReportBase field name for CodeQL CLI version. It should be codeql_version instead of codeql_cli_version.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@cklin cklin marked this pull request as ready for review March 23, 2022 18:35
@cklin cklin requested a review from a team as a code owner March 23, 2022 18:35
adityasharad
adityasharad approved these changes Mar 23, 2022
View reviewed changes
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we got PR checks that would catch incorrect fields by failing the status reporting?

@cklin
Copy link
Contributor Author

cklin commented Mar 23, 2022

Have we got PR checks that would catch incorrect fields by failing the status reporting?

I am not sure if there is a way to do that. I think the status reporting API endpoint is specifically configured to accept unknown fields, which is generally a good thing. That does make it hard to catch field name errors—I found this one only because I was digging into the status report data and noticing that the CodeQL CLI version is always empty.

@cklin cklin merged commit c9973ef into github:main Mar 23, 2022
@cklin cklin deleted the fix-codeql-version-field branch March 23, 2022 20:11
This was referenced Mar 30, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasharad adityasharad adityasharad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cklin @adityasharad