M9-3-3: exclude uninstantiated templates from static query

github · Jun 19, 2024 · 199ad0b · 199ad0b
1 parent f1e1f21
commit 199ad0b
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/change_notes/2024-06-18-fix-fp-616-M9-3-3.md b/change_notes/2024-06-18-fix-fp-616-M9-3-3.md
@@ -0,0 +1,2 @@
+- `M9-3-3` - `MemberFunctionStaticIfPossible.ql`:
+  - Fixes #616. Exclude uninstantiated templates.
diff --git a/cpp/autosar/src/rules/M9-3-3/MemberFunctionStaticIfPossible.ql b/cpp/autosar/src/rules/M9-3-3/MemberFunctionStaticIfPossible.ql
@@ -31,7 +31,8 @@ class NonStaticMemberFunction extends MemberFunction {
     not this instanceof Constructor and
     not this instanceof Destructor and
     not this instanceof Operator and
-    this.hasDefinition()
+    this.hasDefinition() and
+    not this.isFromUninstantiatedTemplate(_)
   }
 }
 

diff --git a/cpp/autosar/test/rules/M9-3-3/test.cpp b/cpp/autosar/test/rules/M9-3-3/test.cpp
@@ -214,4 +214,11 @@ void fp_reported_in_381() {
   Z4 z;
   int i = z.front();
   z.fill(i);
-}
+}
+
+class ZZ {
+public:
+  template <typename T>
+  void fp_616(const T &val) {
+  } // COMPLIANT - ignore uninstantiated templates for static also
+};